Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add splashViewUrl and splashViewHtml fields #989

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Conversation

boiawang
Copy link
Contributor

{
  "splash_view_html": "<!DOCTYPE html><html><body><p> Hello World </p></body></html>",
  "splash_view_url": "http://gc.alibaba-inc.com/splashView",
}

@boiawang boiawang requested review from SoloJiang and jwxbond March 31, 2022 07:29
@SoloJiang
Copy link
Contributor

rax-app 里的版本号改下

@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2022

Codecov Report

Merging #989 (c0fbef3) into master (c14c8a1) will increase coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head c0fbef3 differs from pull request most recent head f87d272. Consider uploading reports for the commit f87d272 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #989      +/-   ##
==========================================
+ Coverage   51.52%   51.59%   +0.07%     
==========================================
  Files          47       48       +1     
  Lines        1281     1283       +2     
  Branches      297      297              
==========================================
+ Hits          660      662       +2     
  Misses        621      621              
Impacted Files Coverage Δ
packages/plugin-rax-pha/src/manifestHelpers.js 33.62% <100.00%> (-0.57%) ⬇️
packages/plugin-rax-pha/src/manifestWhiteList.js 100.00% <100.00%> (ø)

@SoloJiang SoloJiang changed the base branch from master to release-next March 31, 2022 07:51
@SoloJiang SoloJiang merged commit 6c2ee66 into release-next Mar 31, 2022
@SoloJiang SoloJiang deleted the feat/pha branch March 31, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants