fix: only inject webpack hot client in webpack4 #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release-next #986 +/- ##
=============================================
Coverage 51.59% 51.59%
=============================================
Files 48 48
Lines 1283 1283
Branches 297 297
=============================================
Hits 662 662
Misses 621 621 |
wjq990112
approved these changes
Mar 17, 2022
|
webpack5 下确认下 devServer 的 overlay 是否已开启 |
ClarkXia
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webpack5 和 webpack4 stat 信息中 error 的格式不同，导致 webpack5 如果注入低版本的 react-dev-utils/webpackHotClient 在用户构建有 warning 时报错阻塞项目运行，同时由于 webpack5 本身已经内置了相关能力，所以可以在 webpack5 的时候不注入该代码