Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various improvements to CLI error logging and handling. #30

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Various improvements to CLI error logging and handling. #30

merged 2 commits into from
Jul 10, 2023

Conversation

miguelbranco80
Copy link
Contributor

Ensure parser logs are reported correctly.
Ensure runtime or inference errors do not get doubly logged.

torcato
torcato approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@torcato torcato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miguelbranco80 miguelbranco80 merged commit 1d3e4c6 into main Jul 10, 2023
@miguelbranco80 miguelbranco80 deleted the cli-error-handling-fixes branch July 10, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torcato torcato torcato approved these changes

@alexzerntev alexzerntev alexzerntev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miguelbranco80 @torcato @alexzerntev