Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct dataset persistence issues #140

Merged
merged 3 commits into from
Feb 8, 2021
Merged

Correct dataset persistence issues #140

merged 3 commits into from
Feb 8, 2021

Conversation

sjperkins
Copy link
Member

  • Tests added / passed

    $ py.test -v -s daskms/tests

    If the pep8 tests fail, the quickest way to correct
    this is to run autopep8 and then flake8 and
    pycodestyle to fix the remaining issues.

    $ pip install -U autopep8 flake8 pycodestyle
    $ autopep8 -r -i daskms
    $ flake8 daskms
    $ pycodestyle daskms
    
  • Fully documented, including HISTORY.rst for all changes
    and one of the docs/*-api.rst files for new API

    To build the docs locally:

    pip install -r requirements.readthedocs.txt
    cd docs
    READTHEDOCS=True make html
    

@sjperkins
Copy link
Member Author

Caused by pydata/xarray#4882

@sjperkins sjperkins changed the title Fix dataset issues Correct dataset persistence issues Feb 8, 2021
@sjperkins sjperkins merged commit 2d17de0 into master Feb 8, 2021
@sjperkins sjperkins deleted the fix-dataset-issues branch February 8, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant