Release action #34
Release action #34
Conversation
* tweak release publishing settings.
| - linux | ||
| - windows | ||
| - darwin | ||
| - id: sbom |
There was a problem hiding this comment.
Is our intent to provide signed releases of every standalone plugin?
| tags: | ||
| - 'v*' | ||
|
|
||
| jobs: |
There was a problem hiding this comment.
A sample image of how the release looks might be helpful?
There was a problem hiding this comment.
| uses: goreleaser/goreleaser-action@v2 | ||
| with: | ||
| version: latest | ||
| args: release --rm-dist |
There was a problem hiding this comment.
maybe we can add dist/* to our .gitignore. I see your change for ignoring dist, do we still need this --rm-dist?
There was a problem hiding this comment.
It might not be strictly necessary but I think it will help with insuring clean builds especially if we start making this more complicated.
| dir: plugins/verifier/sbom | ||
| binary: sbom | ||
| env: | ||
| - CGO_ENABLED=0 |
There was a problem hiding this comment.
From my little bit of research this looks like it will make our packaged binary more portable. The default is 1, it seems like that means our packaged binaries can look for various C-runtime binaries on the machine it's running on and would fail if they are missing. With 0 it sounds like everything will be included in the packaged binary.
| - darwin | ||
| - id: sbom | ||
| dir: plugins/verifier/sbom | ||
| binary: sbom |
There was a problem hiding this comment.
Is there a reason as to why we are building only one plugin? We need to think about how we release our plugins
There was a problem hiding this comment.
I was just following what Makefile builds. I can include more.
There was a problem hiding this comment.
I would say let's track this as another issue if we want to add more assets to the build.
| snapshot: | ||
| name_template: "{{ incpatch .Version }}-next" | ||
| changelog: | ||
| sort: asc |
There was a problem hiding this comment.
is it by commit time? will it preferred to be desc?
There was a problem hiding this comment.
It will be by commit message in alphabetical order.
| sort: asc | ||
| filters: | ||
| exclude: | ||
| - '^docs:' |
|
Fixes #16 |
|
If there are more comments - let's open them as issues. |
* initial goreleaser and action configuration * * update release documentation * tweak release publishing settings. * some documentation edits * tweak some Go settings and add names
Adds a goreleaser action that will create a draft release when pushing a tag that begins with v*. The release can be reviewed and release notes enhanced before being published.
Also update release documentation to reflect this action.