Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update err-msg with notation #1775

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

junczhu
Copy link
Collaborator

@junczhu junczhu commented Sep 3, 2024

Description

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes error msg in notation verifier.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • CI

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/verifier/notation/notation.go 50.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
pkg/verifier/notation/notation.go 98.07% <50.00%> (+9.95%) ⬆️

... and 18 files with indirect coverage changes

@junczhu
Copy link
Collaborator Author

junczhu commented Sep 3, 2024

We have a corner case that cannot be covered by test on line 261

The check is necessary by following Marshall best practice, and I will have the coverage improved after recover mentioned in issue #1752

In conclusion we can skip the coverage test for this PR.

cc\ @binbin-li

pkg/verifier/notation/notation.go Outdated Show resolved Hide resolved
pkg/verifier/notation/notation.go Outdated Show resolved Hide resolved
pkg/verifier/notation/notation.go Outdated Show resolved Hide resolved
@junczhu junczhu merged commit 7208f98 into ratify-project:dev Sep 5, 2024
18 of 19 checks passed
akashsinghal pushed a commit to akashsinghal/ratify that referenced this pull request Sep 13, 2024
binbin-li added a commit to binbin-li/ratify that referenced this pull request Sep 14, 2024
@junczhu junczhu deleted the notation-err-msg branch January 13, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants