-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update contributing guide for enhancement #1715
Conversation
Signed-off-by: Susan Shi <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Susan Shi <[email protected]>
Signed-off-by: Susan Shi <[email protected]>
Hi @binbin-li, @junczhu , @binbin-li this is ready for review again. thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for adding it!
@susanshi you may need to update title |
Signed-off-by: Susan Shi <[email protected]>
Signed-off-by: Susan Shi <[email protected]> Signed-off-by: akashsinghal <[email protected]>
Signed-off-by: Susan Shi <[email protected]>
Description
What this PR does / why we need it:
adding a section for examples of design doc process
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change