Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add job to delete dev package versions #1532

Merged
merged 2 commits into from
Jun 1, 2024

Conversation

binbin-li
Copy link
Collaborator

Description

What this PR does / why we need it:

  1. Add a job to delete dev package versions before releasing. It will keep the latest 7 versions which is the tagged version and its untagged multi-arch versions.
  2. I made it only triggered manually.
  3. There are 2 reasons I don't add it as release step: 1) This action can delete at most 100 versions one time, so I need to run it several times to clean up all versions. 2) It's not fully tested as a stable option.

I tested on my forked repo, which keeps the latest 7 versions.
image

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.15%. Comparing base (52f92d1) to head (3bafc56).
Report is 6 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1532   +/-   ##
=======================================
  Coverage   68.15%   68.15%           
=======================================
  Files         119      119           
  Lines        6139     6139           
=======================================
  Hits         4184     4184           
  Misses       1561     1561           
  Partials      394      394           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@akashsinghal akashsinghal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @binbin-li for adding this!

@binbin-li binbin-li enabled auto-merge June 1, 2024 15:58
@binbin-li binbin-li merged commit 8a6f018 into ratify-project:dev Jun 1, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants