-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: switch azure ci test to use rbac for key vault access #1523
ci: switch azure ci test to use rbac for key vault access #1523
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1523 +/- ##
==========================================
+ Coverage 66.76% 68.15% +1.38%
==========================================
Files 116 119 +3
Lines 6030 6139 +109
==========================================
+ Hits 4026 4184 +158
+ Misses 1620 1561 -59
- Partials 384 394 +10 ☔ View full report in Codecov by Sentry. |
passing AKS tests here: https://github.com/akashsinghal/ratify/actions/runs/9294373195/job/25579403501 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thanks!
Looks good to me. Do you think this is ready to merge @binbin-li ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for the fix!
…ject#1523) Signed-off-by: akashsinghal <[email protected]>
Description
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change