-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add a proposal for periodic retrieval #1510
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
docs/proposals/Periodic-Retrieval-of-Certificates-and-Keys-from-AKV.md
Outdated
Show resolved
Hide resolved
docs/proposals/Periodic-Retrieval-of-Certificates-and-Keys-from-AKV.md
Outdated
Show resolved
Hide resolved
docs/proposals/Periodic-Retrieval-of-Certificates-and-Keys-from-AKV.md
Outdated
Show resolved
Hide resolved
docs/proposals/Periodic-Retrieval-of-Certificates-and-Keys-from-AKV.md
Outdated
Show resolved
Hide resolved
docs/proposals/Periodic-Retrieval-of-Certificates-and-Keys-from-AKV.md
Outdated
Show resolved
Hide resolved
docs/proposals/Periodic-Retrieval-of-Certificates-and-Keys-from-AKV.md
Outdated
Show resolved
Hide resolved
docs/proposals/Periodic-Retrieval-of-Certificates-and-Keys-from-AKV.md
Outdated
Show resolved
Hide resolved
docs/proposals/Periodic-Retrieval-of-Certificates-and-Keys-from-AKV.md
Outdated
Show resolved
Hide resolved
Hi @duffney, Yi's have proposed the desired experience for KMP refresh. Please review and comment, thanks! |
docs/proposals/Periodic-Retrieval-of-Certificates-and-Keys-from-AKV.md
Outdated
Show resolved
Hide resolved
docs/proposals/Periodic-Retrieval-of-Certificates-and-Keys-from-AKV.md
Outdated
Show resolved
Hide resolved
docs/proposals/Periodic-Retrieval-of-Certificates-and-Keys-from-AKV.md
Outdated
Show resolved
Hide resolved
docs/proposals/Periodic-Retrieval-of-Certificates-and-Keys-from-AKV.md
Outdated
Show resolved
Hide resolved
docs/proposals/Periodic-Retrieval-of-Certificates-and-Keys-from-AKV.md
Outdated
Show resolved
Hide resolved
docs/proposals/Periodic-Retrieval-of-Certificates-and-Keys-from-AKV.md
Outdated
Show resolved
Hide resolved
docs/proposals/Periodic-Retrieval-of-Certificates-and-Keys-from-AKV.md
Outdated
Show resolved
Hide resolved
Thanks @susanshi @bureado @binbin-li @akashsinghal for comments. I am updating the PR now and will ask for another round of review soon. |
@susanshi @bureado @binbin-li @akashsinghal @shizhMSFT @duffney would you mind reviewing this PR again. We can walk through the comments during community meetings. I updated this PR by adding comparison for various KMS, and add a section for proposed solutions by comparing two methods. |
@yizha1 have we thought about scenarios where a user misconfigures the certificate permissions or provides the wrong reference. In this case, how should Ratify respond? Should it immediately start to fail signature validation or do we need some sort of "pre check" so that a misconfiguration doesn't accidentally block resource creation. OR is it ok if user errors results in potential resource creation blocking. |
@susanshi @akashsinghal would you mind reviewing this PR again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing all comments! lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thanks Yi!
Signed-off-by: Yi Zha <[email protected]>
Head branch was pushed to by a user without write access
Signed-off-by: Yi Zha <[email protected]> Signed-off-by: akashsinghal <[email protected]>
Signed-off-by: Yi Zha <[email protected]>
Description
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):This is the proposal for issue #1131
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change