Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add a proposal for periodic retrieval #1510

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

yizha1
Copy link
Collaborator

@yizha1 yizha1 commented May 26, 2024

Description

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

This is the proposal for issue #1131

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

Copy link

codecov bot commented May 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@yizha1 yizha1 marked this pull request as ready for review May 28, 2024 03:10
@binbin-li binbin-li changed the base branch from main to dev May 28, 2024 03:13
@susanshi
Copy link
Collaborator

Hi @duffney, Yi's have proposed the desired experience for KMP refresh. Please review and comment, thanks!

@yizha1
Copy link
Collaborator Author

yizha1 commented Jun 3, 2024

Thanks @susanshi @bureado @binbin-li @akashsinghal for comments. I am updating the PR now and will ask for another round of review soon.

@yizha1
Copy link
Collaborator Author

yizha1 commented Jun 5, 2024

@susanshi @bureado @binbin-li @akashsinghal @shizhMSFT @duffney would you mind reviewing this PR again. We can walk through the comments during community meetings. I updated this PR by adding comparison for various KMS, and add a section for proposed solutions by comparing two methods.

@akashsinghal
Copy link
Collaborator

@yizha1 have we thought about scenarios where a user misconfigures the certificate permissions or provides the wrong reference. In this case, how should Ratify respond? Should it immediately start to fail signature validation or do we need some sort of "pre check" so that a misconfiguration doesn't accidentally block resource creation. OR is it ok if user errors results in potential resource creation blocking.

@yizha1
Copy link
Collaborator Author

yizha1 commented Jun 13, 2024

@susanshi @akashsinghal would you mind reviewing this PR again?

Copy link
Collaborator

@akashsinghal akashsinghal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all comments! lgtm

Copy link
Collaborator

@susanshi susanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks Yi!

@susanshi susanshi enabled auto-merge (squash) June 18, 2024 00:05
auto-merge was automatically disabled June 18, 2024 03:46

Head branch was pushed to by a user without write access

@susanshi susanshi enabled auto-merge (squash) June 18, 2024 03:47
@susanshi susanshi merged commit 6c197b8 into ratify-project:dev Jun 18, 2024
16 checks passed
@yizha1 yizha1 deleted the add_proposal branch June 18, 2024 04:22
akashsinghal pushed a commit to akashsinghal/ratify that referenced this pull request Sep 13, 2024
binbin-li pushed a commit to binbin-li/ratify that referenced this pull request Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants