-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add NamespacedKMP and switch KMP scope to cluster [multi-tenancy PR 9] #1422
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1422 +/- ##
==========================================
- Coverage 66.76% 66.33% -0.44%
==========================================
Files 116 118 +2
Lines 6030 6107 +77
==========================================
+ Hits 4026 4051 +25
- Misses 1620 1672 +52
Partials 384 384 ☔ View full report in Codecov by Sentry. |
05c79e9
to
71b6004
Compare
71b6004
to
d06b1a0
Compare
6cbc4b8
to
96f8ad3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thanks!
…y PR 9] (ratify-project#1422) Signed-off-by: akashsinghal <[email protected]>
Description
What this PR does / why we need it:
This is the 9th PR for multi-tenancy support.
NamespacedKeyManagementProvider
to replace the previousKeyManagementProvider
for namespaced KMP resource.KeyManagementProvider
CRD.Name
instead ofNamespacedName
, which means we'll getProviderName
instead of/ProviderName
as an example.Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change