-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add key support to key management provider #1333
feat: add key support to key management provider #1333
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## staging #1333 +/- ##
===========================================
- Coverage 65.31% 65.20% -0.12%
===========================================
Files 105 105
Lines 5458 5521 +63
===========================================
+ Hits 3565 3600 +35
- Misses 1535 1567 +32
+ Partials 358 354 -4 ☔ View full report in Codecov by Sentry. |
7764cb4
to
48328fa
Compare
295e606
to
0b11743
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR! left some questions for keys test coverage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
What this PR does / why we need it:
This is the 2nd in a series of PRs to enable a brand new cosign experience.
notationCert
value (update docs). and deprecateakvCertConfig
section in favor of newazurekeyvault
section.Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #1296
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change