Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing CRD conversion methods #1289

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

binbin-li
Copy link
Collaborator

@binbin-li binbin-li commented Jan 31, 2024

Description

What this PR does / why we need it:

  1. Add version and status fields to unversioned store and verifier.
  2. Add missing conversion methods to alpha1 verifier and store.
  3. Fix failing unit tests by creating test plugins in a temporary directory.

The unit tests only failed during local development on VS Code since we don't install those plugins under required path.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2f47715) 61.72% compared to head (03621d2) 61.72%.

❗ Current head 03621d2 differs from pull request most recent head 3fae149. Consider uploading reports for the commit 3fae149 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1289   +/-   ##
=======================================
  Coverage   61.72%   61.72%           
=======================================
  Files          97       97           
  Lines        6236     6236           
=======================================
  Hits         3849     3849           
  Misses       2054     2054           
  Partials      333      333           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@binbin-li binbin-li force-pushed the add-missing-conversions branch from dd739b7 to 95a6536 Compare January 31, 2024 06:59
@binbin-li binbin-li force-pushed the add-missing-conversions branch from 95a6536 to 03621d2 Compare January 31, 2024 13:00
Copy link
Collaborator

@susanshi susanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank so much for the fix Binbin. Looks good to me.

@susanshi susanshi merged commit 5225247 into ratify-project:main Feb 1, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants