Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve plugin config dependency #1223

Conversation

junczhu
Copy link
Collaborator

@junczhu junczhu commented Dec 15, 2023

Description

What this PR does / why we need it:

  • Removed plugin config file loading when start server, in K8s mode, and only support CR loading (CLI mode still support config file loading)
  • Added e2e tests and logs for new edge cases
  • Further support multi-tenancy, which only support CR loading

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #1104

  • Remove config load for policy
  • Remove config load for verifier
  • Remove config load for store
  • Add error log when doing verify in k8s and CR not found

Client: image
K8s log: image

Client: image
K8s log: image

Client: image
K8s log: image

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b2bf323) 61.44% compared to head (36fb1c8) 61.69%.

Files Patch % Lines
httpserver/handlers.go 88.46% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1223      +/-   ##
==========================================
+ Coverage   61.44%   61.69%   +0.24%     
==========================================
  Files          97       97              
  Lines        6181     6192      +11     
==========================================
+ Hits         3798     3820      +22     
+ Misses       2051     2039      -12     
- Partials      332      333       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@junczhu junczhu changed the title feat: improve plugin config dependency feat: [WIP]improve plugin config dependency Dec 19, 2023
@junczhu junczhu changed the title feat: [WIP]improve plugin config dependency feat: improve plugin config dependency Dec 19, 2023
@junczhu junczhu marked this pull request as ready for review December 22, 2023 00:38
@junczhu junczhu requested a review from akashsinghal December 30, 2023 04:27
charts/ratify/templates/deployment.yaml Show resolved Hide resolved
httpserver/handlers.go Outdated Show resolved Hide resolved
@junczhu junczhu marked this pull request as draft January 2, 2024 14:26
@junczhu junczhu marked this pull request as ready for review January 2, 2024 15:31
@junczhu junczhu enabled auto-merge (squash) January 2, 2024 17:01
httpserver/handlers.go Outdated Show resolved Hide resolved
httpserver/handlers.go Outdated Show resolved Hide resolved
@junczhu junczhu requested a review from binbin-li January 3, 2024 07:17
@junczhu junczhu merged commit 018cde4 into ratify-project:main Jan 5, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Start server without plugin configs.
3 participants