Merge pull request #1656 from binbin-li/template-result

chore: rephrase failure result in constraint template

docs/design/Config Policy Provider Refactor.md

@@ -245,7 +245,7 @@ spec:
         general_violation[{"result": result}] {
           subject_validation := remote_data.responses[_]
           failed_verify(subject_validation[1].nestedReports)
-          result := sprintf("Subject failed verification: %s", [subject_validation[0]])
+          result := sprintf("Failed to verify the artifact: %s", [subject_validation[0]])
         }
       libs:
         - |
@@ -309,7 +309,7 @@ spec:
         general_violation[{"result": result}] {
           subject_validation := remote_data.responses[_]
           failed_verify(subject_validation[1].nestedReports)
-          result := sprintf("Subject failed verification: %s", [subject_validation[0]])
+          result := sprintf("Failed to verify the artifact: %s", [subject_validation[0]])
         }
       libs:
         - |
@@ -367,7 +367,7 @@ spec:
         general_violation[{"result": result}] {
           subject_validation := remote_data.responses[_]
           failed_verify(subject_validate[1])
-          result := sprintf("Subject failed verification: %s", [subject_validation[0]])
+          result := sprintf("Failed to verify the artifact: %s", [subject_validation[0]])
         }
       libs:
         - |
@@ -466,7 +466,7 @@ spec:
         general_violation[{"result": result}] {
           subject_validation := remote_data.responses[_]
           failed_verify(subject_validate[1])
-          result := sprintf("Subject failed verification: %s", [subject_validation[0]])
+          result := sprintf("Failed to verify the artifact: %s", [subject_validation[0]])
         }
 
         # check if there is an invalid subject

library/default/template.yaml

@@ -11,7 +11,7 @@ spec:
     - target: admission.k8s.gatekeeper.sh
       rego: |
         package ratifyverification
-        
+
         # Get data from Ratify
         remote_data := response {
           images := [img | img = input.review.object.spec.containers[_].image]
@@ -26,23 +26,23 @@ spec:
         violation[{"msg": msg}] {
           general_violation[{"result": msg}]
         }
-        
+
         # Check if there are any system errors
         general_violation[{"result": result}] {
           err := remote_data.system_error
           err != ""
           result := sprintf("System error calling external data provider: %s", [err])
         }
-        
+
         # Check if there are errors for any of the images
         general_violation[{"result": result}] {
           count(remote_data.errors) > 0
           result := sprintf("Error validating one or more images: %s", remote_data.errors)
         }
-        
+
         # Check if the success criteria is true
         general_violation[{"result": result}] {
           subject_validation := remote_data.responses[_]
           subject_validation[1].isSuccess == false
-          result := sprintf("Subject failed verification: %s", [subject_validation[0]])
+          result := sprintf("Failed to verify the artifact: %s", [subject_validation[0]])
         }

library/multi-tenancy-validation/template.yaml

@@ -44,5 +44,5 @@ spec:
         general_violation[{"result": result}] {
           subject_validation := remote_data.responses[_]
           subject_validation[1].isSuccess == false
-          result := sprintf("Subject failed verification: %s", [subject_validation[0]])
+          result := sprintf("Failed to verify the artifact: %s", [subject_validation[0]])
         }

library/notation-issuer-validation/template.yaml

@@ -17,7 +17,7 @@ spec:
     - target: admission.k8s.gatekeeper.sh
       rego: |
         package notationissuervalidation
-        
+
         # Get data from Ratify
         remote_data := response {
           images := [img | img = input.review.object.spec.containers[_].image]
@@ -32,25 +32,25 @@ spec:
         violation[{"msg": msg}] {
           general_violation[{"result": msg}]
         }
-        
+
         # Check if there are any system errors
         general_violation[{"result": result}] {
           err := remote_data.system_error
           err != ""
           result := sprintf("System error calling external data provider: %s", [err])
         }
-        
+
         # Check if there are errors for any of the images
         general_violation[{"result": result}] {
           count(remote_data.errors) > 0
           result := sprintf("Error validating one or more images: %s", remote_data.errors)
         }
-        
+
         # Check if the success criteria is true
         general_violation[{"result": result}] {
           subject_validation := remote_data.responses[_]
           subject_validation[1].isSuccess == false
-          result := sprintf("Subject failed verification: %s", [subject_validation[0]])
+          result := sprintf("Failed to verify the artifact: %s", [subject_validation[0]])
         }
 
         # Check that signature result for Issuer exists
@@ -62,7 +62,7 @@ spec:
           count(issuer_results) == 0
           result := sprintf("Subject %s has no signatures for certificate with Issuer: %s", [subject_results[0], input.parameters.issuer])
         }
-        
+
         # Check for valid signature
         general_violation[{"result": result}] {
           subject_results := remote_data.responses[_]

library/notation-nested-validation/template.yaml

@@ -57,7 +57,7 @@ spec:
           subject_validation := remote_data.responses[_]
           subject_result := subject_validation[1]
           failed_verify(subject_result)
-          result := sprintf("Subject failed verification: %s", [subject_validation[0]])
+          result := sprintf("Failed to verify the artifact: %s", [subject_validation[0]])
         }
 
         failed_verify(reports) if {
@@ -85,4 +85,3 @@ spec:
           ]
           number := count(sigs)
         }
-