use questionmark operator instead of try! #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Performance regression ( Before: running 3 tests
test codegen_from_ast ... bench: 627 ns/iter (+/- 319) = 641 MB/s
test parse_to_ast ... bench: 4,814 ns/iter (+/- 35) = 249 MB/s
test parse_to_ast_and_transform_es5 ... bench: 5,075 ns/iter (+/- 711) = 236 MB/sAfter: running 3 tests
test codegen_from_ast ... bench: 625 ns/iter (+/- 4) = 643 MB/s
test parse_to_ast ... bench: 5,850 ns/iter (+/- 262) = 204 MB/s
test parse_to_ast_and_transform_es5 ... bench: 6,135 ns/iter (+/- 20) = 195 MB/s |
|
On hold due to rust-lang/rust#37939 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.