Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detachDescriptor causes error with fixes for #115 in place #117

Closed
silkentrance opened this issue Mar 24, 2017 · 3 comments · Fixed by #119
Closed

detachDescriptor causes error with fixes for #115 in place #117

silkentrance opened this issue Mar 24, 2017 · 3 comments · Fixed by #119

Comments

@silkentrance
Copy link
Collaborator

silkentrance commented Mar 24, 2017 •
edited
Loading

The problem here is that in the removeCallback it tests for fdPath[0] being LTE 0, which is wrong, it should read -1 != fdPath[0].

This might have been found due to the side effect caused by moving the unlinkSync() back into the try block, which had been moved out of that block, causing the fix for #115 to fail.
silkentrance added a commit that referenced this issue Mar 24, 2017
@silkentrance
Fixes #115
2eb39e8 
Fixes #117
Add node 7 to travis build matrix
silkentrance added a commit that referenced this issue Mar 24, 2017
@silkentrance
Fixes #115
02fc69f 
Fixes #117
Add node 7 to travis build matrix
Bump version to 0.0.32
@silkentrance
Copy link
Collaborator Author

Fixed with latest commit 02fc69f.

@raszi
Copy link
Owner

raszi commented Mar 24, 2017 •
edited
Loading

Did you want to close this issue? Because that branch has not been merged yet.

@silkentrance
Copy link
Collaborator Author

silkentrance commented Mar 24, 2017 •
edited
Loading

Yes, I ran the tests on that branch on both appveyor and travis-ci and they work as expected.
Erm, perhaps wee bit premature, reopening.

@silkentrance silkentrance reopened this Mar 24, 2017
@silkentrance silkentrance mentioned this issue Apr 5, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #115 raszi/node-tmp
2 participants
@raszi @silkentrance