Use common pico-vscode.cmake file #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulober
reviewed
Aug 16, 2024
| "endif()\n" | ||
| f"set(sdkVersion {params['sdkVersion']})\n" | ||
| f"set(toolchainVersion {params['toolchainVersion']})\n" | ||
| f"set(picotoolVersion {params['picotoolVersion']})\n" |
There was a problem hiding this comment.
Great, this also directly fixes an issue I noticed during testing that currently the extension always generates a CMakeLists.txt with a picoTool version equal to it's selected SDK version (see L593).
paulober
reviewed
Aug 16, 2024
paulober
approved these changes
Aug 16, 2024
Instead of different DO NEVER EDIT lines for each SDK version, include a common file which does all that logic Update any existing CMakeLists.txt files to this new style when extension is loaded
Use USERHOME, rather than a full path
will-v-pi
force-pushed
the
cmake-include
branch
from
96dd2b4 to
c2d6918
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of different DO NEVER EDIT lines for each SDK version, include a common file which does all that logic
Update any existing CMakeLists.txt files to this new style when extension is loaded, and also copy the pico-vscode.cmake into place whenever the extension is loaded to ensure it is up-to-date
This will make future updates which require changes to that section of the file much simpler, as the separate pico-vscode.cmake file can be updated instead