drm:vc4 Added calls for firmware display blank/unblank #3289
Conversation
|
Fixes #3050 |
JamesH65
force-pushed
the
pi4_screen_blanking
branch
from
b929714 to
e9c52f7
Compare
| @@ -272,6 +278,7 @@ struct vc4_fkms_encoder { | |||
| struct drm_encoder base; | |||
| bool hdmi_monitor; | |||
| bool rgb_range_selectable; | |||
| int display_num; | |||
There was a problem hiding this comment.
I feel that this should be accessible from either the crtc or connector (the bits either side of the encoder).
In reality I get lost with the potential dereferencing between the structures, and this driver is fairly monolithic anyway.
There was a problem hiding this comment.
I did spend about 45 minutes trying to find a way of getting this information from the existing structures, and it ended up being so convoluted that adding this parameter was a hugely simpler option - both from an implementation and understanding point of view.
There was a problem hiding this comment.
Fair enough. I know that finding the right linkings can be less than obvious.
Requires new display power mailbox call to be present. Signed-off-by: James Hughes <[email protected]>
JamesH65
force-pushed
the
pi4_screen_blanking
branch
from
e9c52f7 to
11e0604
Compare
|
@popcornmix This can be merged now that that required mailbox command in the firmware has been merged, unless you want a short delay to wait for it to go out in rpi-update. |
See: raspberrypi/linux#3296 kernel: dts: bcm2838: Disable DWC OTG block by default kernel: ALSA: usb-audio: Add Gustard U16/X26 to quirks for native DSD support See: raspberrypi/linux#3295 kernel: bcm2835-v4l2-codec fixes See: raspberrypi/linux#3293 kernel: drm:vc4 Added calls for firmware display blank/unblank See: raspberrypi/linux#3289 firmware: arm_loader: Fix explicit kernel name handling See: #1277 firmware: Added a new display power mailbox call firmware: Update display_power gencmd with optional display id See: raspberrypi/linux#3050 firmware: Remove legacy pkgconfig to avoid Mesa conflicts See: raspberrypi/userland#585
See: raspberrypi/linux#3296 kernel: dts: bcm2838: Disable DWC OTG block by default kernel: ALSA: usb-audio: Add Gustard U16/X26 to quirks for native DSD support See: raspberrypi/linux#3295 kernel: bcm2835-v4l2-codec fixes See: raspberrypi/linux#3293 kernel: drm:vc4 Added calls for firmware display blank/unblank See: raspberrypi/linux#3289 firmware: arm_loader: Fix explicit kernel name handling See: raspberrypi/firmware#1277 firmware: Added a new display power mailbox call firmware: Update display_power gencmd with optional display id See: raspberrypi/linux#3050 firmware: Remove legacy pkgconfig to avoid Mesa conflicts See: raspberrypi/userland#585
Requires new display power mailbox call to be present.
Signed-off-by: James Hughes [email protected]