Add compress/decompress tests for lzop(1) compatibility #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rminnich
force-pushed
the
decompresslzoptest
branch
from
60643b2 to
fb35ef9
Compare
rminnich
force-pushed
the
decompresslzoptest
branch
2 times, most recently
from
f14ff9e to
3c287be
Compare
Make existing decompress tests a bit more idiomatic by having them check returned error values. Add two tests which compare uncompressed and compressed output from lzop(1). Currently, we can now uncompress data compressed with lzop -1. The choice of 0x32 as the starting point is sketchy however. Make debug prints conditioned on a variable (Verbose), not commented out, and expose both Verbose and the print function (Debug) so users of this package can set them. Debug defaults to an empty function. For the loops where we do not want to continually call an empty function, Verbose is used to control whether we call Debug at all. Signed-off-by: Ronald G Minnich <[email protected]>
rminnich
force-pushed
the
decompresslzoptest
branch
from
3c287be to
922225d
Compare
Signed-off-by: Ronald G Minnich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make existing decompress tests a bit more idiomatic by having them
check returned error values.
Add two tests which compare uncompressed and compressed output from lzop(1).
Currently, we can now uncompress data compressed with lzop -1.
Make debug prints conditioned on a variable (Verbose), not commented out, and expose
both Verbose and the print function (Debug) so users of this package can set them.
Debug defaults to an empty function.
For the loops where we do not want to continually call an empty function, Verbose
is used to control whether we call Debug at all.
Still kind of a WIP, comments appreciated. I actually have a need for this package in u-root.
Signed-off-by: Ronald G Minnich [email protected]