-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Simplify the setup in CI * windows --no-binary option * windows uv workflow * add path * some fixes * some fixes * some fixes * cleanup * cleanup * cleanup * cleanup * cleanup * more windows issues * more windows issues * more windows issues * more windows issues * more windows issues * more windows issues * more windows issues * more windows issues * revert
- Loading branch information
Showing
14 changed files
with
160 additions
and
39 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
name: Code tests Windows (uv/pip) | ||
|
||
on: | ||
push: | ||
branches: [ main ] | ||
paths: | ||
- '**/*.py' | ||
- '**/*.ipynb' | ||
- '**/*.yaml' | ||
- '**/*.yml' | ||
- '**/*.sh' | ||
pull_request: | ||
branches: [ main ] | ||
paths: | ||
- '**/*.py' | ||
- '**/*.ipynb' | ||
- '**/*.yaml' | ||
- '**/*.yml' | ||
- '**/*.sh' | ||
|
||
jobs: | ||
test: | ||
runs-on: windows-latest | ||
|
||
steps: | ||
- name: Checkout Code | ||
uses: actions/checkout@v4 | ||
|
||
- name: Set up Python | ||
uses: actions/setup-python@v5 | ||
with: | ||
python-version: "3.13" | ||
|
||
- name: Install dependencies | ||
shell: pwsh | ||
run: | | ||
$env:Path = "C:\Users\runneradmin\.local\bin;$env:Path" | ||
python -m pip install --upgrade pip | ||
python -m pip install uv | ||
uv venv --python=python3.11 | ||
. .\.venv\Scripts\Activate.ps1 | ||
$env:UV_PIP_OPTS="--no-binary tensorflow-io-gcs-filesystem" | ||
uv pip install -r requirements.txt | ||
uv pip install -r ch05/07_gpt_to_llama/tests/test-requirements-extra.txt | ||
uv pip install pytest-ruff nbval | ||
uv pip install --force-reinstall matplotlib "numpy<2.1" | ||
|
||
- name: Run Python Tests | ||
shell: pwsh | ||
run: | | ||
$env:Path = "C:\Users\runneradmin\.local\bin;$env:Path" | ||
. .\.venv\Scripts\Activate.ps1 | ||
pytest --ruff setup/02_installing-python-libraries/tests.py | ||
pytest --ruff ch04/01_main-chapter-code/tests.py | ||
pytest --ruff ch05/01_main-chapter-code/tests.py | ||
pytest --ruff ch05/07_gpt_to_llama/tests/tests.py | ||
pytest --ruff ch06/01_main-chapter-code/tests.py | ||
|
||
- name: Run Jupyter Notebook Tests | ||
shell: pwsh | ||
run: | | ||
$env:Path = "C:\Users\runneradmin\.local\bin;$env:Path" | ||
. .\.venv\Scripts\Activate.ps1 | ||
pytest --ruff --nbval ch02/01_main-chapter-code/dataloader.ipynb | ||
pytest --ruff --nbval ch03/01_main-chapter-code/multihead-attention.ipynb | ||
pytest --ruff --nbval ch02/04_bonus_dataloader-intuition/dataloader-intuition.ipynb |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
name: Code tests Windows (uv) | ||
|
||
on: | ||
push: | ||
branches: [ main ] | ||
paths: | ||
- '**/*.py' | ||
- '**/*.ipynb' | ||
- '**/*.yaml' | ||
- '**/*.yml' | ||
- '**/*.sh' | ||
pull_request: | ||
branches: [ main ] | ||
paths: | ||
- '**/*.py' | ||
- '**/*.ipynb' | ||
- '**/*.yaml' | ||
- '**/*.yml' | ||
- '**/*.sh' | ||
|
||
jobs: | ||
test: | ||
runs-on: windows-latest | ||
|
||
steps: | ||
- name: Checkout Code | ||
uses: actions/checkout@v4 | ||
|
||
- name: Set up Python | ||
uses: actions/setup-python@v5 | ||
with: | ||
python-version: "3.13" | ||
|
||
- name: Install dependencies | ||
shell: pwsh | ||
run: | | ||
# Prepend local bin directory to PATH | ||
powershell -ExecutionPolicy ByPass -c "irm https://astral.sh/uv/install.ps1 | iex" | ||
$env:Path = "C:\Users\runneradmin\.local\bin;$env:Path" | ||
uv sync --dev --python=3.10 | ||
$env:UV_PIP_OPTS="--no-binary tensorflow-io-gcs-filesystem" | ||
uv pip install -r requirements.txt | ||
uv pip install matplotlib # for some reason Windows requires this | ||
uv pip install -r ch05/07_gpt_to_llama/tests/test-requirements-extra.txt | ||
uv add pytest-ruff nbval | ||
|
||
- name: Run Python Tests | ||
shell: pwsh | ||
run: | | ||
. .\.venv\Scripts\Activate.ps1 | ||
pytest --ruff setup/02_installing-python-libraries/tests.py | ||
pytest --ruff ch04/01_main-chapter-code/tests.py | ||
pytest --ruff ch05/01_main-chapter-code/tests.py | ||
pytest --ruff ch05/07_gpt_to_llama/tests/tests.py | ||
pytest --ruff ch06/01_main-chapter-code/tests.py | ||
|
||
- name: Run Jupyter Notebook Tests | ||
shell: pwsh | ||
run: | | ||
. .\.venv\Scripts\Activate.ps1 | ||
pytest --ruff --nbval ch02/01_main-chapter-code/dataloader.ipynb | ||
pytest --ruff --nbval ch03/01_main-chapter-code/multihead-attention.ipynb | ||
pytest --ruff --nbval ch02/04_bonus_dataloader-intuition/dataloader-intuition.ipynb |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,9 @@ | ||
torch >= 2.3.0 # all | ||
jupyterlab >= 4.0 # all | ||
tiktoken >= 0.5.1 # ch02; ch04; ch05 | ||
matplotlib >= 3.7.1 # ch04; ch05 | ||
tensorflow>=2.18.0; sys_platform != "win32" # ch05 (non-Windows) | ||
tensorflow-cpu>=2.18.0; sys_platform == "win32" # ch05 (Windows) | ||
tqdm >= 4.66.1 # ch05; ch07 | ||
numpy >= 1.26, < 2.1 # dependency of several other libraries like torch and pandas | ||
pandas >= 2.2.1 # ch06 | ||
psutil >= 5.9.5 # ch07; already installed automatically as dependency of torch | ||
torch >= 2.3.0 # all | ||
jupyterlab >= 4.0 # all | ||
tiktoken >= 0.5.1 # ch02; ch04; ch05 | ||
matplotlib >= 3.7.1 # ch04; ch06; ch07 | ||
tensorflow>=2.18.0 # ch05; ch06; ch07 | ||
tqdm >= 4.66.1 # ch05; ch07 | ||
numpy >= 1.26, < 2.1 # dependency of several other libraries like torch and pandas | ||
pandas >= 2.2.1 # ch06 | ||
psutil >= 5.9.5 # ch07; already installed automatically as dependency of torch |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters