This repository has been archived by the owner on Nov 25, 2024. It is now read-only.
manage more dependencies in dependencies.yaml, declare 'numpy' runtime dependency #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
improvement
jameslamb
changed the title
jameslamb
changed the title
rapids-bot bot
pushed a commit
to rapidsai/cugraph-gnn
that referenced
this pull request
Oct 21, 2024
This PR introduces full end-to-end CI for wholegraph. ## Notes for Reviewers Most of these changes were pulled from a mix of the following: * #53 * rapidsai/wholegraph#230 * https://github.com/rapidsai/wholegraph Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Alex Barghi (https://github.com/alexbarghi-nv) - Jake Awe (https://github.com/AyodeAwe) URL: #58
KyleFromNVIDIA
approved these changes
Oct 23, 2024
|
Thanks for the thorough review, @KyleFromNVIDIA |
|
/merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on adding CI for
wholegraphin the newcugraph-gnnrepo (rapidsai/cugraph-gnn#58), I noticed a few issues here.pylibwholegraphimportsnumpyat runtime, but its wheels and conda package don't declare a runtime dependency onnumpyrapids-dependency-file-generatorwholegraph_bindingCython code imports NumPy but doesn't use itpip installcalls instead of a single one to get all dependencies (see combine pip install calls in wheel-testing scripts cugraph#4701)This proposes fixes for those things.
Notes for Reviewers
Where is the NumPy runtime dependency coming from?
wholegraph/python/pylibwholegraph/pylibwholegraph/torch/data_loader.py
Line 14 in 0efba33