Type handle_as_int as uintptr_t in signature
#574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Linting error is being fixed in PR ( #575 ). |
|
rerun tests |
jakirkham
force-pushed
the
type_hdl_int
branch
2 times, most recently
from
91f0719 to
10ed126
Compare
Go ahead and type `handle_as_int` as `uintptr_t` in the function signature, Cython already knows how to convert generic Python `int`s to `uintptr_t` without intervention. Plus it simplifies the code internally.
jakirkham
force-pushed
the
type_hdl_int
branch
from
10ed126 to
a668cff
Compare
|
Any thoughts on this @madsbk? |
|
Thanks Mads! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go ahead and type
handle_as_intasuintptr_tin the function signature, Cython already knows how to convert generic Pythonints touintptr_twithout intervention. Plus it simplifies the code internally.