Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional continue-on-error input to CI jobs #280

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Add optional continue-on-error input to CI jobs #280

merged 1 commit into from
Feb 12, 2025

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Feb 12, 2025

Occasionally we want the ability to not block merging PRs even if one of the CI jobs is failing. xref rapidsai/cudf#17987. This pr add the continue-on-error input so that this is possible.

@Matt711 Matt711 requested a review from a team as a code owner February 12, 2025 10:42
@Matt711 Matt711 requested a review from gforsyth February 12, 2025 10:42
@Matt711 Matt711 changed the title Add optional continue-on-error to CI jobs Add optional continue-on-error input to CI jobs Feb 12, 2025
@Matt711 Matt711 mentioned this pull request Feb 12, 2025
Merged
3 tasks
gforsyth
gforsyth reviewed Feb 12, 2025
View reviewed changes
Copy link
Contributor

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure, the goal here is for the workflow to report success even if some steps fail, yes?

@Matt711
Copy link
Contributor Author

Matt711 commented Feb 12, 2025

Just to make sure, the goal here is for the workflow to report success even if some steps fail, yes?

Yes

@gforsyth gforsyth added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Feb 12, 2025
gforsyth
gforsyth approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Matt711 ! Just wanted to confirm intent because continue-on-error can have unintuitive effects

@gforsyth gforsyth merged commit 520981d into rapidsai:branch-25.04 Feb 12, 2025
1 check passed
rapids-bot bot pushed a commit to rapidsai/cudf that referenced this pull request Feb 13, 2025
@Matt711
Continue on failures in cudf.pandas integration tests CI job (#17987)
359d936 
Make the third-party integration tests CI job optional for merging. This PR depends on rapidsai/shared-workflows#280

Authors:
  - Matthew Murray (https://github.com/Matt711)
  - Matthew Roeschke (https://github.com/mroeschke)
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)
  - GALI PREM SAGAR (https://github.com/galipremsagar)

URL: #17987
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gforsyth gforsyth gforsyth approved these changes

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Matt711 @gforsyth