Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-label PRs based on their content [skip-ci] #681

Merged
merged 5 commits into from
Feb 3, 2021
Merged

Auto-label PRs based on their content [skip-ci] #681

merged 5 commits into from
Feb 3, 2021

Conversation

jolorunyomi
Copy link
Contributor

@jolorunyomi jolorunyomi commented Jan 25, 2021 •
edited
Loading

This PR adds the GitHub action PR Labeler to auto-label PRs based on their content.

Labeling is managed with a configuration file .github/labeler.yml using the following options.

@github-actions github-actions bot added the Ops label Jan 25, 2021
@jolorunyomi jolorunyomi marked this pull request as ready for review January 25, 2021 13:43
@jolorunyomi jolorunyomi requested a review from a team as a code owner January 25, 2021 13:43
@ajschmidt8
Copy link
Member

Is this a duplicate of #680?

mike-wendt
mike-wendt suggested changes Jan 27, 2021
View reviewed changes
.github/labeler.yml Show resolved Hide resolved
.github/labeler.yml Show resolved Hide resolved
@mike-wendt mike-wendt added 3 - Ready for review Ready for review by team and removed Ops labels Jan 27, 2021
@mike-wendt
Copy link
Contributor

@jrhemstad @harrism I think there may be some missing labels here but can you provide feedback so we can get this in for 0.18?

@harrism
Copy link
Member

harrism commented Jan 27, 2021

@jrhemstad @harrism I think there may be some missing labels here but can you provide feedback so we can get this in for 0.18?

There is not enough information in the description and the changes in this PR for me to understand exactly what it does. Examples would help.

@ajschmidt8
Copy link
Member

@jrhemstad @harrism I think there may be some missing labels here but can you provide feedback so we can get this in for 0.18?

There is not enough information in the description and the changes in this PR for me to understand exactly what it does. Examples would help.

@harrism, this PR adds some automation to label PRs when they're opened. As an example, the configuration below will automatically label any PRs that edit files in the python directory with the Python label.

Python:
  - 'python/**'

@github-actions github-actions bot added the Ops label Jan 27, 2021
kkraus14
kkraus14 reviewed Jan 27, 2021
View reviewed changes
.github/labeler.yml Outdated
@@ -12,5 +12,8 @@ CMake:
conda:
- 'conda/**'

cpp:
- 'cpp/**'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't currently have a cpp folder in the rmm repo. This should be include/ unless we want to reorganize the code.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or rather should include include/, tests/ and doxygen/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree.

@jolorunyomi jolorunyomi changed the title update pr-labeler configuration Auto-label PRs based on their content [skip-ci] Jan 29, 2021
@mike-wendt mike-wendt added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed 3 - Ready for review Ready for review by team labels Jan 29, 2021
@mike-wendt mike-wendt added 4 - Needs Reviewer Waiting for reviewer to review or respond and removed Ops labels Jan 29, 2021
@kkraus14
Copy link
Contributor

note we still need to make a cpp label

@mike-wendt
Copy link
Contributor

note we still need to make a cpp label

@kkraus14 it will get auto-generated just without a color; just like the Ops label (we'll remove that after the config is updated otherwise it will be recreated)

@harrism harrism removed the 4 - Needs Reviewer Waiting for reviewer to review or respond label Feb 2, 2021
@harrism
Copy link
Member

harrism commented Feb 2, 2021

Is this ready to merge? @jolorunyomi @mike-wendt

@jolorunyomi jolorunyomi merged commit 0a8bf00 into branch-0.18 Feb 3, 2021
@ajschmidt8 ajschmidt8 deleted the rmm-pr-labeler branch February 3, 2021 15:04
@mike-wendt mike-wendt restored the rmm-pr-labeler branch February 3, 2021 15:07
@ajschmidt8 ajschmidt8 mentioned this pull request Feb 3, 2021
Merged
@ajschmidt8
Copy link
Member

removing the labels from this PR to prevent it from appearing in the changelog since it was re-merged correctly (squash merged) in #691.

rapids-bot bot pushed a commit that referenced this pull request Feb 3, 2021
@ajschmidt8
Auto-label PRs based on their content (#691)
729918c 
This PR adds the GitHub action [PR Labeler](https://github.com/actions/labeler) to auto-label PRs based on their content. 

Labeling is managed with a configuration file `.github/labeler.yml` using the following [options](https://github.com/actions/labeler#usage).

**Note: ** This is a duplicate of #681 that we're re-merging since it was merged incorrectly.

Authors:
  - AJ Schmidt (@ajschmidt8)
  - Joseph (@jolorunyomi)

Approvers:
  - Joseph (@jolorunyomi)

URL: #691
@ajschmidt8 ajschmidt8 deleted the rmm-pr-labeler branch February 3, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@mike-wendt mike-wendt mike-wendt approved these changes

@kkraus14 kkraus14 kkraus14 approved these changes

@jrhemstad jrhemstad Awaiting requested review from jrhemstad

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jolorunyomi @ajschmidt8 @mike-wendt @harrism @kkraus14