Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable codecov #1171

Merged
merged 5 commits into from
Nov 30, 2022
Merged

Enable codecov #1171

merged 5 commits into from
Nov 30, 2022

Conversation

ajschmidt8
Copy link
Member

Description

This PR enables codecov for GitHub Actions for rmm. The codecov results can be placed in the directory defined by the RAPIDS_COVERAGE_DIR variable, which is set in our shared workflows.

Additionally, this PR configures the unit test results to be placed in the directory defined by the RAPIDS_TESTS_DIR variable, which is also set in our shared workflows.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the ci label Nov 30, 2022
@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 30, 2022
ci/test_python.sh Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.02@d132e52). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff               @@
##             branch-23.02   #1171   +/-   ##
==============================================
  Coverage                ?   0.00%           
==============================================
  Files                   ?       5           
  Lines                   ?     406           
  Branches                ?       0           
==============================================
  Hits                    ?       0           
  Misses                  ?     406           
  Partials                ?       0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ajschmidt8 ajschmidt8 marked this pull request as ready for review November 30, 2022 22:18
@ajschmidt8 ajschmidt8 requested a review from a team as a code owner November 30, 2022 22:18
@ajschmidt8 ajschmidt8 requested a review from bdice November 30, 2022 22:18
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, after you merge the upstream PR and change the branch names back.

@ajschmidt8 ajschmidt8 merged commit 8a01696 into rapidsai:branch-23.02 Nov 30, 2022
@ajschmidt8 ajschmidt8 deleted the codecov branch November 30, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants