Synchronize stream in DeviceBuffer.c_from_unique_ptr constructor
#1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rerun tests |
harrism
approved these changes
Sep 27, 2022
|
rerun tests |
|
@ashwin is this a 22.10 code freeze blocker? If you merge the latest 22.10 branch CI should work now. |
|
I missed this PR because it is not assigned to a project. |
|
@shwina I believe the above query from Mark Harris is meant for you. 😊 |
|
Oops, sorry. |
…ix-c-from-unique-ptr-sync
|
Retargeting, as I don't want to introduce this change so late into the release. So far it has never bitten us... |
jakirkham
approved these changes
Sep 29, 2022
|
rerun tests |
|
@shwina should we get this into 23.04? Seems like it dropped off all our radars but not for any particular reason. |
|
Retargeted to |
|
/merge |
|
Thanks all! 🙏 If we find anything else is needed here, please raise an issue (or PR) and we can follow up from there 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DeviceBuffer.__cinit__method syncs the default stream to ensure that access to the.ptrand.sizeattributes of the underlyingrmm::device_bufferis safe.However, the staticmethod
DeviceBuffer.c_from_unique_ptrdoes not. This PR adds a stream sync to it.