Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PyNVML 11 for now #210

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

jakirkham
Copy link
Member

PyNVML 12 will depend on nvidia-ml-py and drop its equivalent functionality. So it will largely become a metapackage with some utilities. This will mean using a much newer version of the NVML functionality through Python than is currently used in RAPIDS. As a preventive step, stick to PyNVML 11, which is what RAPIDS already uses.

Then when PyNVML 12 is released, this can be relaxed on a project-by-project basis to see if it unconvers any issues that will need project-level fixes.

PyNVML 12 will depend on nvidia-ml-py and drop its equivalent
functionality. So it will largely become a metapackage with some
utilities. This will mean using a much newer version of the NVML
functionality through Python than is currently used in RAPIDS. As a
preventive step, stick to PyNVML 11, which is what RAPIDS already uses.

Then when PyNVML 12 is released, this can be relaxed on a
project-by-project basis to see if it unconvers any issues that will
need project-level fixes.
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks John!

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jakirkham

@jacobtomlinson jacobtomlinson merged commit afe994e into rapidsai:branch-0.12 Nov 26, 2024
11 checks passed
@jakirkham jakirkham deleted the req_pynvml_11 branch November 26, 2024 17:04
@jakirkham
Copy link
Member Author

Thanks all! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants