Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing of device by UUID #780

Merged
merged 5 commits into from
Nov 15, 2021
Merged

Fix parsing of device by UUID #780

merged 5 commits into from
Nov 15, 2021

Conversation

pentschev
Copy link
Member

With this change, specifying GPUs via their UUIDs in CUDA_VISIBLE_DEVICES should work again. Add tests for LocalCUDACluster/dask-cuda-worker.

@pentschev pentschev requested a review from a team as a code owner November 12, 2021 15:17
@github-actions github-actions bot added the python python code needed label Nov 12, 2021
@pentschev pentschev added 3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change labels Nov 12, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@965f5cd). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12     #780   +/-   ##
===============================================
  Coverage                ?   89.41%           
===============================================
  Files                   ?       15           
  Lines                   ?     1984           
  Branches                ?        0           
===============================================
  Hits                    ?     1774           
  Misses                  ?      210           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 965f5cd...e107011. Read the comment docs.

madsbk
madsbk requested changes Nov 15, 2021
View reviewed changes
Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @pentschev, have some minor suggestions

@pentschev
Copy link
Member Author

rerun tests

@pentschev
Copy link
Member Author

Thanks @madsbk for the review!

@pentschev
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 52808b8 into rapidsai:branch-21.12 Nov 15, 2021
@pentschev pentschev deleted the fix-gpu-uuid branch November 22, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsbk madsbk madsbk approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change python python code needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pentschev @codecov-commenter @madsbk