Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Fix registering correct dispatches for cudf.Index #718

Merged
merged 1 commit into from
Sep 2, 2021
Merged

[REVIEW] Fix registering correct dispatches for cudf.Index #718

merged 1 commit into from
Sep 2, 2021

Conversation

galipremsagar
Copy link
Contributor

Fixes: #715

With the recent cudf refactor done in rapidsai/cudf#8309, we will need to update cudf.Index to cudf.BaseIndex at these places.

@galipremsagar galipremsagar requested a review from a team as a code owner September 2, 2021 21:01
@github-actions github-actions bot added the python python code needed label Sep 2, 2021
@galipremsagar galipremsagar mentioned this pull request Sep 2, 2021
Closed
@quasiben quasiben added 3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change labels Sep 2, 2021
@quasiben
Copy link
Member

quasiben commented Sep 2, 2021

Thanks @galipremsagar !

@quasiben
Copy link
Member

quasiben commented Sep 2, 2021

@gpucibot merge

@galipremsagar
Copy link
Contributor Author

Thanks for the quick review @quasiben ! 🎉

@jakirkham
Copy link
Member

Thanks Prem! 😄

@rapids-bot rapids-bot bot merged commit a077463 into rapidsai:branch-21.10 Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quasiben quasiben quasiben approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change python python code needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non-numeric dtypes fail __cuda_array_interface__ check
3 participants
@galipremsagar @quasiben @jakirkham