Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leave interface unset when ucx_net_devices unset in LocalCUDACluster #711

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Leave interface unset when ucx_net_devices unset in LocalCUDACluster #711

merged 1 commit into from
Aug 26, 2021

Conversation

pentschev
Copy link
Member

Setting interface when ucx_net_devices=None causes failures with RDMACM, as the interface defined by the user to handle connections is overwritten.

@pentschev pentschev requested a review from a team as a code owner August 25, 2021 18:49
@pentschev pentschev added 3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change labels Aug 25, 2021
@github-actions github-actions bot added the python python code needed label Aug 25, 2021
madsbk
madsbk approved these changes Aug 26, 2021
View reviewed changes
Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pentschev

@pentschev
Copy link
Member Author

Thanks for the review and approval @madsbk !

@pentschev
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 93ed185 into rapidsai:branch-21.10 Aug 26, 2021
@pentschev pentschev deleted the unset-interface branch September 22, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsbk madsbk madsbk approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change python python code needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pentschev @madsbk