Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device memory limit argument to benchmarks #683

Merged
merged 3 commits into from
Jul 23, 2021
Merged

Add device memory limit argument to benchmarks #683

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab055e9
Add device memory limit arg to benchmarks
charlesbluca Jul 23, 2021
ea19586
Put device_memory_limit in worker options for multinode case
charlesbluca Jul 23, 2021
af7d4c4
Specify memory limit in worker options
charlesbluca Jul 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions dask_cuda/benchmarks/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,16 @@ def parse_benchmark_args(description="Generic dask-cuda Benchmark", args_list=[]
type=str,
help="Write dask profile report (E.g. dask-report.html)",
)
parser.add_argument(
"--device-memory-limit",
default=None,
type=parse_bytes,
help="Size of the CUDA device LRU cache, which is used to determine when the "
"worker starts spilling to host memory. Can be an integer (bytes), float "
"(fraction of total device memory), string (like ``'5GB'`` or ``'5000M'``), or "
"``'auto'``, 0, or ``None`` to disable spilling to host (i.e. allow full "
"device memory usage).",
)
parser.add_argument(
"--rmm-pool-size",
default=None,
Expand Down Expand Up @@ -203,6 +213,8 @@ def get_cluster_options(args):
if args.enable_rdmacm:
worker_options["enable_rdmacm"] = ""

if args.device_memory_limit:
worker_options["device_memory_limit"] = args.device_memory_limit
if args.ucx_net_devices:
worker_options["ucx_net_devices"] = args.ucx_net_devices

Expand All @@ -229,6 +241,7 @@ def get_cluster_options(args):
"enable_nvlink": args.enable_nvlink,
"enable_rdmacm": args.enable_rdmacm,
"interface": args.interface,
"device_memory_limit": args.device_memory_limit,
}
if args.no_silence_logs:
cluster_kwargs["silence_logs"] = False
Expand Down