Skip to content

Commit

Permalink
Use aliases to check for installed UCX version (#692)
Browse files Browse the repository at this point in the history
Fixes #691

Authors:
  - Peter Andreas Entschev (https://github.com/pentschev)

Approvers:
  - Charles Blackmon-Luca (https://github.com/charlesbluca)
  - Benjamin Zaitlen (https://github.com/quasiben)

URL: #692
  • Loading branch information
pentschev authored Jul 28, 2021
1 parent a0217f4 commit c9e3907
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion dask_cuda/tests/test_dgx.py
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ def _timeout_callback():
def test_dask_cuda_worker_ucx_net_devices(enable_rdmacm):
ucp = pytest.importorskip("ucp") # NOQA: F841

if ucp.get_ucx_version() >= (1, 10, 0):
if _ucx_110:
pytest.skip("UCX 1.10 and higher should rely on default UCX_NET_DEVICES")

p = mp.Process(
Expand Down
2 changes: 1 addition & 1 deletion dask_cuda/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ def get_device_total_memory(index=0):
def get_ucx_net_devices(
cuda_device_index, ucx_net_devices, get_openfabrics=True, get_network=False
):
if ucp.get_ucx_version() >= (1, 11, 0) and ucx_net_devices == "auto":
if _ucx_111 and ucx_net_devices == "auto":
return None

if cuda_device_index is None and (
Expand Down

0 comments on commit c9e3907

Please sign in to comment.