Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Enable discussions #966

Merged
merged 4 commits into from
Mar 6, 2023

Conversation

jarmak-nv
Copy link
Contributor

@jarmak-nv jarmak-nv commented Mar 1, 2023

Description

This PR removes the Question issue type and template in favor of using GitHub Discussions. The new file, config.yml, adds a link in our discussions in the submit issue page so it works just like an issue template.

Reasoning

[QST] issues are largely inactionable and hard to act upon, it's better for us to discuss a question/comment/thought and then file a feature/bug/doc request as needed at the end of the conversation. It allows for free-form discussion and prevents the problem of 'when is a question done?' for closing the issue.

This should not be merged until Discussions are enabled, so the https://github.com/rapidsai/cuspatial/labels/5%20-%20DO%20NOT%20MERGE label has been applied. (Thanks @raydouglass!)

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jarmak-nv jarmak-nv added the DO NOT MERGE Hold off on merging; see PR for details label Mar 1, 2023
@jarmak-nv jarmak-nv requested a review from a team as a code owner March 1, 2023 21:13
@jarmak-nv jarmak-nv requested a review from harrism March 1, 2023 21:29
@jarmak-nv jarmak-nv added improvement Improvement / enhancement to an existing function 3 - Ready for Review Ready for review by team non-breaking Non-breaking change and removed DO NOT MERGE Hold off on merging; see PR for details labels Mar 1, 2023
@harrism
Copy link
Member

harrism commented Mar 6, 2023

/merge

@ajschmidt8
Copy link
Member

@harrism, it looks like your /merge comment had some trailing whitespace which prevented it from working properly. I will re-comment.

@ajschmidt8
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 262cb26 into rapidsai:branch-23.04 Mar 6, 2023
@harrism
Copy link
Member

harrism commented Mar 6, 2023

I can't see any trailing whitespace, even if I click edit on my comment. Perhaps /merge should ignore trailing whitespace?

@ajschmidt8
Copy link
Member

I can't see any trailing whitespace, even if I click edit on my comment. Perhaps /merge should ignore trailing whitespace?

I saw some new lines when I clicked Edit on your comment.

But agreed. This is the second time this week that whitespace prevented a merge from working correctly.

Just pushed the commit below to trim whitespace from the merge comment. It will be deployed and take effect in a few minutes.

@harrism
Copy link
Member

harrism commented Mar 7, 2023

Thanks!

@jarmak-nv jarmak-nv deleted the enable-discussions branch March 17, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

5 participants