Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Libcudf Test Macro #841

Merged
merged 2 commits into from
Dec 5, 2022
Merged

Use Libcudf Test Macro #841

merged 2 commits into from
Dec 5, 2022

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Dec 3, 2022

Description

Following rapidsai/cudf#12242, this PR updates libcuspatial tests with cudf test macros.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@isVoid isVoid requested a review from a team as a code owner December 3, 2022 01:11
@github-actions github-actions bot added the libcuspatial Relates to the cuSpatial C++ library label Dec 3, 2022
@isVoid isVoid added tests Relating to tests and test automation non-breaking Non-breaking change labels Dec 3, 2022
@isVoid isVoid requested review from thomcom and harrism and removed request for zhangjianting and jrhemstad December 3, 2022 01:27
@isVoid isVoid added the improvement Improvement / enhancement to an existing function label Dec 3, 2022
@thomcom
Copy link
Contributor

thomcom commented Dec 5, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 886e1c9 into rapidsai:branch-23.02 Dec 5, 2022
@bdice
Copy link
Contributor

bdice commented Dec 5, 2022

Thanks so much @isVoid @harrism @thomcom! This unblocked me on GitHub Actions (#836).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomcom thomcom thomcom approved these changes

@harrism harrism harrism approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change tests Relating to tests and test automation
Projects
cuSpatial
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@isVoid @thomcom @bdice @harrism