Allow None rows in GeoSeries and an align method to match GeoPandas
#760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
libcuspatial
thomcom
added
2 - In Progress
harrism
reviewed
Nov 1, 2022
thomcom
added
4 - Needs Reviewer
isVoid
requested changes
Nov 2, 2022
isVoid
approved these changes
Nov 3, 2022
There was a problem hiding this comment.
Thanks, lgtm.
Pending one (non-blocking) question about design here: #760 (comment)
Co-authored-by: Michael Wang <[email protected]>
|
rerun tests |
harrism
reviewed
Nov 7, 2022
Comment on lines
579
to
581
| >>> polygons_right = gpd.GeoSeries([ | ||
| Point((-2, -2)), | ||
| Point((-8, -8)), |
There was a problem hiding this comment.
Why is this called polygons_right if it contains Points, not Polygons?
|
|
||
| def align(self, other): | ||
| """ | ||
| Align the rows of two GeoSeries using outer join. |
There was a problem hiding this comment.
What does it mean to align the rows of geoseries? I think a more detailed explanation would help.
There was a problem hiding this comment.
I will write one that covers this implementation.
There was a problem hiding this comment.
I increased the docs, explaining three use cases, and provided examples for them. Please approve and merge @harrism .
harrism
approved these changes
Nov 28, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows us to have
GeoSerieswith empty rows containingNone. This feature is used by GeoPandas frequently with binary operations onGeoSeriesof different lengths. It also adds analignmethod which works with default arguments for aligning the indices of aSeriesand adding None where rows are missing.I also updated the internals for
GeoColumn,GeoSeries, andGeoDataFrameto handle native_gatheroperations from cudf correctly. This eliminates the need to usecolumn._dataas a reordering map whensort_valuesis used on a non-geometry column, and should support more hidden cudf operations that we haven't attempted yet.Closes #762
Closes #761
Checklist