Add missing rmm includes #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrism
requested review from
isVoid
and removed request for
zhangjianting and
jrhemstad
harrism
added
3 - Ready for Review
isVoid
approved these changes
Jul 14, 2022
cpp/include/cuspatial/error.hpp
Outdated
| @@ -16,8 +16,9 @@ | |||
|
|
|||
| #pragma once | |||
|
|
|||
| #include <cuda.h> | |||
| //#include <cuda.h> | |||
There was a problem hiding this comment.
We should remove this because it's redundant of cuda_runtime_api.h?
There was a problem hiding this comment.
Oops, I was testing commenting it out and forgot to remove it. Yes, will remove.
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change to libcudf removed a forward declaration and/or RMM header includes, and cuSpatial was errantly relying on these to get the definitions of
device_memory_resourceandget_current_device_resource().This PR fixes that by adding missing includes of
rmm/mr/device/per_device_resource.hppin several files. It also generally cleans up include ordering and spacing, and adds a few missing copyright headers.