Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove itstimestamp and types.hpp #554

Merged
merged 3 commits into from
Jun 17, 2022
Merged

Remove itstimestamp and types.hpp #554

merged 3 commits into from
Jun 17, 2022

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Jun 3, 2022

This PR removes itstimestamp and types.hpp as they are not used in current code base. closes #540

@isVoid isVoid requested a review from a team as a code owner June 3, 2022 17:40
@isVoid isVoid requested review from cwharris and zhangjianting June 3, 2022 17:41
@github-actions github-actions bot added the libcuspatial Relates to the cuSpatial C++ library label Jun 3, 2022
@harrism harrism added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 6, 2022
harrism
harrism requested changes Jun 6, 2022
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Perhaps we need a cuda_utils.hpp or somewhere like that to put the host/device macro.

@isVoid isVoid requested a review from harrism June 8, 2022 19:02
@isVoid
Copy link
Contributor Author

isVoid commented Jun 17, 2022

rerun tests

@isVoid
Copy link
Contributor Author

isVoid commented Jun 17, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 6f4c3e7 into rapidsai:branch-22.08 Jun 17, 2022
isVoid added a commit to isVoid/cuspatial that referenced this pull request Jun 23, 2022
@isVoid
Remove itstimestamp and types.hpp (rapidsai#554)
5add705 
This PR removes `itstimestamp` and `types.hpp` as they are not used in current code base. closes rapidsai#540

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - Mark Harris (https://github.com/harrism)

URL: rapidsai#554
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@cwharris cwharris Awaiting requested review from cwharris cwharris is a code owner automatically assigned from rapidsai/cuspatial-cpp-codeowners

@zhangjianting zhangjianting Awaiting requested review from zhangjianting zhangjianting is a code owner automatically assigned from rapidsai/cuspatial-cpp-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
cuSpatial
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove no-longer-used struct its_timestamp
2 participants
@isVoid @harrism