Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace ccache with sccache #483

Merged
merged 8 commits into from
Feb 3, 2022
Merged

replace ccache with sccache #483

merged 8 commits into from
Feb 3, 2022

Conversation

AyodeAwe
Copy link
Contributor

This PR replaces ccache with sccache

@github-actions github-actions bot added conda Related to conda and conda configuration gpuCI Related to Continuous Integration / Automation labels Jan 27, 2022
@AyodeAwe AyodeAwe added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 27, 2022
@AyodeAwe AyodeAwe changed the base branch from branch-22.02 to branch-22.04 January 28, 2022 16:40
@ajschmidt8
Copy link
Member

pre-cache C++ build time (log link): 0:11:48.2

image

@ajschmidt8
Copy link
Member

rerun tests

@ajschmidt8 ajschmidt8 marked this pull request as ready for review February 2, 2022 17:29
@ajschmidt8 ajschmidt8 requested a review from a team as a code owner February 2, 2022 17:29
@ajschmidt8 ajschmidt8 added the DO NOT MERGE Hold off on merging; see PR for details label Feb 2, 2022
@ajschmidt8
Copy link
Member

PR is ready for review, but we'll wait to merge until all the other PRs are confirmed working as well.

ajschmidt8
ajschmidt8 reviewed Feb 2, 2022
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AyodeAwe, can you update this last ccache reference to say sccache?

@ajschmidt8 ajschmidt8 removed the DO NOT MERGE Hold off on merging; see PR for details label Feb 2, 2022
@github-actions github-actions bot added cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library labels Feb 2, 2022
@ajschmidt8
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 98c03a0 into rapidsai:branch-22.04 Feb 3, 2022
@harrism
Copy link
Member

harrism commented Feb 3, 2022

@ajschmidt8 What was the post sccache build time on this one?

@ajschmidt8
Copy link
Member

@ajschmidt8 What was the post sccache build time on this one?

47s!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trxcllnt trxcllnt trxcllnt approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees
No one assigned
Labels
cmake Related to CMake code or build configuration conda Related to conda and conda configuration gpuCI Related to Continuous Integration / Automation improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AyodeAwe @ajschmidt8 @harrism @trxcllnt