[REVIEW] construct quadtree on large-scale point data #143

zhangjianting · 2020-03-26T02:10:00Z

Implementation of an efficient bottom-up approach to constructing quadtree on large-scale point data.

zhangjianting · 2020-03-26T15:27:16Z

rerun test

zhangjianting · 2020-03-26T15:27:45Z

rerun tests

mike-wendt · 2020-03-26T15:30:31Z

@zhangjianting ~~I see the issues, I'm looking at them~~

~~I've replayed the failed job and monitoring...~~ jobs passed, running again to get clean ✅ across all jobs

mike-wendt · 2020-03-26T16:09:56Z

rerun tests

cpp/include/cuspatial/point_quadtree.hpp

cpp/src/indexing/point_quadtree.cu

cwharris

Partial review. It's been sitting here for a couple of days and I haven't gotten back to it yet. Sorry. :(

cpp/src/utility/helper_thrust.cuh

cpp/src/utility/bbox_thrust.cuh

Co-Authored-By: H. Thomson Comer <[email protected]>

codereport

Found a couple things before I realized this is in cuspatial and only showed up in my notifications b/c @cwharris @-ed me XD

CHANGELOG.md

cpp/include/cuspatial/point_quadtree.hpp

Co-Authored-By: Conor Hoekstra <[email protected]>

Co-Authored-By: H. Thomson Comer <[email protected]>

Co-Authored-By: Christopher Harris <[email protected]>

…point-quadtree

cpp/src/utility/quadtree_thrust.cuh

…al into fea-point-quadtree

harrism

Partial review. Just now getting to the meat of it...

CHANGELOG.md

cpp/CMakeLists.txt

cpp/include/cuspatial/point_quadtree.hpp

cpp/src/indexing/point_quadtree.cu

harrism

I think I am about half done. Will continue tomorrow.

cpp/src/indexing/point_quadtree.cu

harrism · 2020-05-14T06:28:54Z

cpp/src/indexing/point_quadtree.cu

+                            quad_point_count.begin(), quad_child_count.begin(),
+                            stream);
+
+    // Shrink vectors' underlying device allocations to reduce peak memory usage


Future optimization: don't bother shrinking if the data size is under a threshold (perhaps an option).

…point-quadtree

cpp/src/indexing/point_quadtree.cu

Co-authored-by: Mark Harris <[email protected]>

harrism

OK, last review. Mostly just more brief docs.

cpp/src/indexing/point_quadtree.cu

…point-quadtree

…than sorting points in-place

trxcllnt · 2020-05-18T16:09:02Z

rerun tests

… readable

trxcllnt · 2020-05-18T21:21:43Z

This is failing at the moment because cudf is installed from last night, but ci/gpu/build.sh is using the headers from today. Since rapidsai/cudf#4972 was merged, the test utils from today are referencing a list_view type that isn't in the cudf/types.hpp from last night.

harrism

Approve, but please run spellcheck.

cpp/include/cuspatial/point_quadtree.hpp

cpp/src/indexing/construction/detail/phase_1.cuh

zhangjianting added 2 commits March 25, 2020 21:40

init check in point quadtree code

a742557

add mising cuda header files; update CMakeLists.txt

8b629de

zhangjianting requested review from a team as code owners March 26, 2020 02:10

zhangjianting added 4 commits March 25, 2020 22:11

update CHANGELOG.md

219ad54

change back to CUDF_ROOT

409470e

fix indcluing wrong head file

8713278

disable tests to avoid CI error on ubuntu18.04-cuda10.2 config

03ebc18

zhangjianting added the 3 - Ready for Review Ready for review by team label Mar 26, 2020

Merge branch 'branch-0.14' into fea-point-quadtree

03d1224

zhangjianting changed the title ~~construct quadtree on large-scale point data~~ [REVIEW] construct quadtree on large-scale point data Mar 26, 2020

Merge branch 'branch-0.14' into fea-point-quadtree

df69bcf

Merge branch 'branch-0.14' into fea-point-quadtree

c02cd54

thomcom reviewed Mar 26, 2020

View reviewed changes

cpp/include/cuspatial/point_quadtree.hpp Outdated Show resolved Hide resolved

thomcom reviewed Mar 26, 2020

View reviewed changes

cpp/src/indexing/point_quadtree.cu Outdated Show resolved Hide resolved

thomcom requested changes Mar 26, 2020

View reviewed changes

cpp/src/indexing/point_quadtree.cu Outdated Show resolved Hide resolved

cwharris reviewed Apr 7, 2020

View reviewed changes

Update cpp/include/cuspatial/point_quadtree.hpp

ef40e16

Co-Authored-By: H. Thomson Comer <[email protected]>

codereport reviewed Apr 8, 2020

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

cpp/include/cuspatial/point_quadtree.hpp Outdated Show resolved Hide resolved

zhangjianting and others added 4 commits April 8, 2020 12:04

Update cpp/include/cuspatial/point_quadtree.hpp

79fe586

Co-Authored-By: Conor Hoekstra <[email protected]>

Update cpp/src/indexing/point_quadtree.cu

0de996d

Co-Authored-By: H. Thomson Comer <[email protected]>

Update cpp/src/utility/bbox_thrust.cuh

28a507b

Co-Authored-By: Christopher Harris <[email protected]>

Merge branch 'branch-0.14' of github.com:rapidsai/cuspatial into fea-…

b3eceea

…point-quadtree

trxcllnt reviewed Apr 15, 2020

View reviewed changes

cpp/src/utility/quadtree_thrust.cuh Outdated Show resolved Hide resolved

trxcllnt added 2 commits April 14, 2020 19:20

run clang-format on files

f4bad8a

add quadtree_on_points detail API

fb3a885

Merge branch 'fea-point-quadtree' of github.com:zhangjianting/cuspati…

4982c8f

…al into fea-point-quadtree

cwharris approved these changes May 13, 2020

View reviewed changes

zhangjianting mentioned this pull request May 14, 2020

[REVIEW] Add quadtree-based point-in-polygon and point-to-nearest-polyline #149

Merged

harrism requested changes May 14, 2020

View reviewed changes

Merge branch 'branch-0.14' of github.com:rapidsai/cuspatial into fea-…

3bfb43c

…point-quadtree

trxcllnt reviewed May 14, 2020

View reviewed changes

cpp/src/indexing/point_quadtree.cu Outdated Show resolved Hide resolved

trxcllnt and others added 2 commits May 14, 2020 03:16

Apply suggestions from code review

2c9787f

Co-authored-by: Mark Harris <[email protected]>

fix a typo, run clang-format, reuse point_keys vector for child_count

15a56cd

harrism requested changes May 15, 2020

View reviewed changes

trxcllnt added 7 commits May 16, 2020 13:53

Merge branch 'branch-0.14' of github.com:rapidsai/cuspatial into fea-…

273fa8c

…point-quadtree

address some review comments, return sorted points gather map rather …

e69dc1c

…than sorting points in-place

use memory resource to construct key_to_point indices

a00901a

flake8

642ec1b

update for more review feedback

3f51b4d

remove duplicated changelog entry

a6d89a7

remove the _real_ duplicated changelog entry

4a243f1

trxcllnt added 2 commits May 18, 2020 12:11

pin to gdal >= 3.0.2 to fix conda environment

2e5adb2

split out point_quadtree.cu into separate files to make it a bit more…

54242dd

… readable

harrism approved these changes May 19, 2020

View reviewed changes

trxcllnt added 3 commits May 19, 2020 09:02

Merge branch 'branch-0.14' into fea-point-quadtree

c4ea312

run clang-format

096717b

fix typos, change const'ness of some variables/parameters

25bd1c8

thomcom approved these changes May 19, 2020

View reviewed changes

trxcllnt approved these changes May 19, 2020

View reviewed changes

trxcllnt merged commit ab95ad4 into rapidsai:branch-0.14 May 19, 2020

zhangjianting deleted the fea-point-quadtree branch October 28, 2020 03:26

trxcllnt mentioned this pull request Feb 4, 2021

Add cuSpatial Quadtree implementation rapidsai/node#74

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[REVIEW] construct quadtree on large-scale point data #143

[REVIEW] construct quadtree on large-scale point data #143

zhangjianting commented Mar 26, 2020 •

edited

Loading

zhangjianting commented Mar 26, 2020

zhangjianting commented Mar 26, 2020

mike-wendt commented Mar 26, 2020 •

edited

Loading

mike-wendt commented Mar 26, 2020

cwharris left a comment

codereport left a comment

harrism left a comment

harrism left a comment

harrism May 14, 2020

harrism left a comment

trxcllnt commented May 18, 2020

trxcllnt commented May 18, 2020

harrism left a comment

[REVIEW] construct quadtree on large-scale point data #143

[REVIEW] construct quadtree on large-scale point data #143

Conversation

zhangjianting commented Mar 26, 2020 • edited Loading

zhangjianting commented Mar 26, 2020

zhangjianting commented Mar 26, 2020

mike-wendt commented Mar 26, 2020 • edited Loading

mike-wendt commented Mar 26, 2020

cwharris left a comment

Choose a reason for hiding this comment

codereport left a comment

Choose a reason for hiding this comment

harrism left a comment

Choose a reason for hiding this comment

harrism left a comment

Choose a reason for hiding this comment

harrism May 14, 2020

Choose a reason for hiding this comment

harrism left a comment

Choose a reason for hiding this comment

trxcllnt commented May 18, 2020

trxcllnt commented May 18, 2020

harrism left a comment

Choose a reason for hiding this comment

zhangjianting commented Mar 26, 2020 •

edited

Loading

mike-wendt commented Mar 26, 2020 •

edited

Loading