Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for pairwise_linestring_polygon_distance, pairwise_polygon_distance #1145

Merged
merged 8 commits into from
Jun 1, 2023
Merged

Add documentation for pairwise_linestring_polygon_distance, pairwise_polygon_distance #1145

merged 8 commits into from
Jun 1, 2023

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented May 19, 2023 •
edited by harrism
Loading

Description

closes #1146

Add missing API examples for 23.06 release.

  • Added example for pairwise_linestring_polygon_distance, pairwise_polygon_distance

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@isVoid isVoid self-assigned this May 22, 2023
@isVoid isVoid added 3 - Ready for Review Ready for review by team doc Documentation non-breaking Non-breaking change labels May 22, 2023
@isVoid isVoid marked this pull request as ready for review May 22, 2023 15:37
@harrism harrism requested review from thomcom and jarmak-nv May 29, 2023 22:44
@harrism harrism added the Python Related to Python code label May 29, 2023
jarmak-nv
jarmak-nv approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@jarmak-nv jarmak-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point we should resolve the FutureWarning on the Natural Earth dataset, but low prio until GeoPandas 1.0 has a set date.

@github-actions github-actions bot removed the Python Related to Python code label May 30, 2023
@isVoid isVoid requested a review from a team as a code owner May 30, 2023 20:02
@github-actions github-actions bot added the conda Related to conda and conda configuration label May 31, 2023
@isVoid isVoid changed the title Miscellaneous Documentation Addition for 23.06 Release Add documentation for pairwise_linestring_polygon_distance, pairwise_polygon_distance May 31, 2023
@harrism
Copy link
Member

harrism commented May 31, 2023 

Warning, treated as error:
/__w/cuspatial/cuspatial/docs/source/user_guide/cuspatial_api_examples.ipynb:653:image file not readable: user_guide/attachment:8c5d8b90-2241-45c2-b98c-20d48d1ee6b7.png

ajschmidt8
ajschmidt8 approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

@isVoid
Copy link
Contributor Author

isVoid commented Jun 1, 2023

/merge

@rapids-bot rapids-bot bot merged commit 400cc15 into rapidsai:branch-23.06 Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@jarmak-nv jarmak-nv jarmak-nv approved these changes

@thomcom thomcom Awaiting requested review from thomcom

Assignees

@isVoid isVoid

Labels
3 - Ready for Review Ready for review by team conda Related to conda and conda configuration doc Documentation non-breaking Non-breaking change
Projects
cuSpatial
Status: Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC]: linestring-polygon and polygon-polygon distance missing user example
4 participants
@isVoid @harrism @ajschmidt8 @jarmak-nv