Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Gtest version following Rapids-cmake change #1126

Merged
merged 3 commits into from
May 9, 2023
Merged

Bump Gtest version following Rapids-cmake change #1126

merged 3 commits into from
May 9, 2023

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented May 8, 2023

Description

Following Rapids-cmake bump to gtest 1.13.0 rapidsai/rapids-cmake#400, this PR implements some custom out stream operator for more constrained ADL rules that 1.11+ uses.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@isVoid isVoid requested review from a team as code owners May 8, 2023 18:08
@isVoid isVoid requested review from trxcllnt and harrism May 8, 2023 18:08
@github-actions github-actions bot added conda Related to conda and conda configuration libcuspatial Relates to the cuSpatial C++ library labels May 8, 2023
@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 8, 2023
ajschmidt8
ajschmidt8 reviewed May 8, 2023
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update

cuspatial/conda/recipes/libcuspatial/conda_build_config.yaml

Line 13 in 8b97a72

gtest_version:
as well?

@thomcom
Copy link
Contributor

thomcom commented May 8, 2023

Also doesn't this cause the build error with operator<< in a couple of gtests?

@isVoid
Copy link
Contributor Author

isVoid commented May 8, 2023

Also doesn't this cause the build error with operator<< in a couple of gtests?

I added a few operator<< fixes in this PR.

@isVoid isVoid requested a review from ajschmidt8 May 8, 2023 22:56
@bdice bdice mentioned this pull request May 9, 2023
Closed
bdice
bdice requested changes May 9, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply the suggestions in this review. Then we should be good to go.

@isVoid isVoid requested review from bdice and ajschmidt8 May 9, 2023 16:34
@isVoid
Copy link
Contributor Author

isVoid commented May 9, 2023

/merge

@rapids-bot rapids-bot bot merged commit 6e56d13 into rapidsai:branch-23.06 May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@bdice bdice bdice approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@trxcllnt trxcllnt Awaiting requested review from trxcllnt trxcllnt is a code owner automatically assigned from rapidsai/cuspatial-cpp-codeowners

Assignees
No one assigned
Labels
conda Related to conda and conda configuration improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@isVoid @thomcom @harrism @bdice @ajschmidt8