Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug in segment intersection primitive where two collinear segment touch at endpoints is miscomputed as a degenerate segment #1093

Merged
merged 7 commits into from
Apr 27, 2023
Merged

Fix a bug in segment intersection primitive where two collinear segment touch at endpoints is miscomputed as a degenerate segment #1093

merged 7 commits into from
Apr 27, 2023

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Apr 25, 2023

Description

Fixes #1091

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@isVoid isVoid requested a review from a team as a code owner April 25, 2023 19:03
@isVoid isVoid requested review from trxcllnt and harrism April 25, 2023 19:03
@github-actions github-actions bot added the libcuspatial Relates to the cuSpatial C++ library label Apr 25, 2023
@isVoid isVoid self-assigned this Apr 25, 2023
@isVoid isVoid added bug Something isn't working non-breaking Non-breaking change labels Apr 25, 2023
@isVoid isVoid requested a review from a team as a code owner April 26, 2023 00:15
@github-actions github-actions bot added the Python Related to Python code label Apr 26, 2023
@isVoid
Copy link
Contributor Author

isVoid commented Apr 27, 2023

/merge

@rapids-bot rapids-bot bot merged commit 86e8912 into rapidsai:branch-23.06 Apr 27, 2023
@isVoid isVoid mentioned this pull request Apr 28, 2023
Merged
3 tasks
@harrism harrism mentioned this pull request May 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@trxcllnt trxcllnt Awaiting requested review from trxcllnt trxcllnt is a code owner automatically assigned from rapidsai/cuspatial-cpp-codeowners

Assignees

@isVoid isVoid

Labels
bug Something isn't working libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change Python Related to Python code
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: pairwise_linestring_intersection returns a degenerate LineString
2 participants
@isVoid @harrism