Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA]: Update clang-format to a recent version #1078

Closed
harrism opened this issue Apr 18, 2023 · 0 comments · Fixed by #1072
Closed

[FEA]: Update clang-format to a recent version #1078

harrism opened this issue Apr 18, 2023 · 0 comments · Fixed by #1072
Assignees
@harrism
Labels
feature request New feature or request

Comments

@harrism
Copy link
Member

harrism commented Apr 18, 2023

Is this a new feature, an improvement, or a change to existing functionality?

New Feature

How would you describe the priority of this feature request

Medium

Please provide a clear description of problem you would like to solve.

RAPIDS is in the process of updating to a more recent clang-format version. This is already in progress in #1072 .

This will help users of the cuspatial devcontainer because it has a newer clang-format version than is used in CI, and there are often style mismatches as a result.

We may use an earlier version than 16.0.1 due to a bug introduced in that version that results in operator* being formatted as if it is a pointer (a* T{1.0} instead of a * T{1.0}). See https://github.com/rapidsai/cugraph-ops/pull/466#discussion_r1168977855

Describe any alternatives you have considered

No response

Additional context

No response
@harrism harrism added feature request New feature or request Needs Triage Need team to review and classify labels Apr 18, 2023
@harrism harrism self-assigned this Apr 18, 2023
@harrism harrism moved this from Todo to In Progress in cuSpatial Apr 18, 2023
@harrism harrism mentioned this issue Apr 18, 2023
Merged
@harrism harrism moved this from In Progress to Review in cuSpatial Apr 19, 2023
rapids-bot bot pushed a commit that referenced this issue Apr 19, 2023
@bdice
Update clang-format to 15.0.7 (#1072)
8f49daa 
This PR updates the clang-format version used by pre-commit.  Fixes #1078.

Authors:
  - Bradley Dice (https://github.com/bdice)
  - Mark Harris (https://github.com/harrism)

Approvers:
  - H. Thomson Comer (https://github.com/thomcom)
  - Mark Harris (https://github.com/harrism)

URL: #1072
@github-project-automation github-project-automation bot moved this from Review to Done in cuSpatial Apr 19, 2023
@jarmak-nv jarmak-nv removed the Needs Triage Need team to review and classify label Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harrism harrism

Labels
feature request New feature or request
Projects
cuSpatial
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update clang-format to 15.0.7 bdice/cuspatial
2 participants
@harrism @jarmak-nv