Fix template argument of DeviceSegmentedReduce kernels
#6459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miscco does this require updating to a newer version of nvcomp? The builds are failing right now. |
|
@vyasr nope, I just need to remember that we still have rapid on 2.7 / 2.8 and not 3.0 That means we need to support both the old and the new interface |
miscco
force-pushed
the
fix_device_segmented_reduce
branch
from
cef8e7b to
552f765
Compare
…ns because of template argument change
miscco
force-pushed
the
fix_device_segmented_reduce
branch
from
552f765 to
c960539
Compare
vyasr
added
improvement
vyasr
approved these changes
Mar 21, 2025
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently changed the
num_segmentsargument to takeint64_tin order to support larger segments