Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #6403
While working on that, my IDE highlighted a few unused imports. Looked into that a bit and saw that this project is currently configured to ignore
flake8
's warnings about unused imports:cuml/python/cuml/.flake8
Lines 27 to 28 in c5c0656
I went back to the PR that introduced that (#4983) and didn't see any discussion that made me think that was the intended long-term state.
This proposes:
flake8
's unused imports checkNotes for Reviewers
Benefits of these changes
Approach I took
Removed
F401
exclusion from.flake8
, then ranManually went through the suggestions and looked at the usage.
For library code:
# noqa: F401
for imports that looked like they were intentional (e.g. for their side effects)For test code:
cuml
itself, via#noqa
comments