[REVIEW] Refactored useful checker macros into a separate header file #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clusion can then be made from non .cu files too
|
@jirikraus I couldn't try the '#include' check of this from a .cpp file, for example. Can you please give it a shot and see if that works for you? |
teju85
changed the title
dantegd
approved these changes
Feb 23, 2019
Salonijain27
pushed a commit
to Salonijain27/cuml
that referenced
this pull request
Jan 22, 2020
Add SVM demo notebook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Their inclusion can then be made from non .cu files too.
Tagging @jirikraus and @vinaydes for review.
@jirikraus I have filed issue #229 for the
CUDA_CHECK_NO_THROWmacro.