Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Fix mypy errors surfacing because of numpy-1.21.0 #8595

Merged
merged 1 commit into from
Jun 23, 2021
Merged

[REVIEW] Fix mypy errors surfacing because of numpy-1.21.0 #8595

merged 1 commit into from
Jun 23, 2021

Conversation

galipremsagar
Copy link
Contributor

This PR fixes mypy errors happening in style checks because of numpy-1.21 upgrade.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 23, 2021
@galipremsagar galipremsagar requested a review from shwina June 23, 2021 16:42
@galipremsagar galipremsagar self-assigned this Jun 23, 2021
@galipremsagar galipremsagar requested a review from a team as a code owner June 23, 2021 16:42
@galipremsagar galipremsagar requested a review from cwharris June 23, 2021 16:42
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Jun 23, 2021
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@shwina shwina mentioned this pull request Jun 23, 2021
Merged
@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #8595 (d9c0835) into branch-21.08 (788bddd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head d9c0835 differs from pull request most recent head b863ba9. Consider uploading reports for the commit b863ba9 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##           branch-21.08    #8595   +/-   ##
=============================================
  Coverage         82.62%   82.62%           
=============================================
  Files               109      109           
  Lines             17859    17860    +1     
=============================================
+ Hits              14756    14757    +1     
  Misses             3103     3103
Impacted Files Coverage Δ
python/cudf/cudf/core/column/numerical.py 94.17% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 788bddd...b863ba9. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 671b76d into rapidsai:branch-21.08 Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwina shwina shwina approved these changes

@cwharris cwharris Awaiting requested review from cwharris

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galipremsagar @shwina