Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct ORC docstring; other minor cuIO improvements #7012

Merged
merged 5 commits into from
Dec 17, 2020

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Dec 15, 2020

Fixes #6923

Included other minor cuIO improvements that are too small for individual PRs:

  • Remove unnecessary NaN-related conditions in JSON, CSV.
  • Expand a comment in createSerializedTrie to make initialization clearer.

@vuule vuule self-assigned this Dec 15, 2020
@vuule vuule added cuIO cuIO issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 15, 2020
@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #7012 (2cc303b) into branch-0.18 (a5515f2) will increase coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #7012      +/-   ##
===============================================
+ Coverage        82.01%   82.29%   +0.28%     
===============================================
  Files               96       96              
  Lines            16340    16627     +287     
===============================================
+ Hits             13402    13684     +282     
- Misses            2938     2943       +5     
Impacted Files Coverage Δ
python/cudf/cudf/utils/ioutils.py 78.71% <ø> (ø)
python/dask_cudf/dask_cudf/io/tests/test_csv.py 100.00% <0.00%> (ø)
python/cudf/cudf/core/column/column.py 88.03% <0.00%> (+0.10%) ⬆️
python/dask_cudf/dask_cudf/core.py 74.01% <0.00%> (+0.32%) ⬆️
python/cudf/cudf/core/column/datetime.py 89.42% <0.00%> (+0.53%) ⬆️
python/cudf/cudf/core/indexing.py 96.35% <0.00%> (+0.72%) ⬆️
python/cudf/cudf/core/column/numerical.py 95.88% <0.00%> (+1.31%) ⬆️
python/dask_cudf/dask_cudf/io/csv.py 96.96% <0.00%> (+1.44%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.04% <0.00%> (+2.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5515f2...2cc303b. Read the comment docs.

@vuule vuule changed the title [WIP] Correct ORC docstring; other minor cuIO improvements Correct ORC docstring; other minor cuIO improvements Dec 15, 2020
@vuule vuule marked this pull request as ready for review December 15, 2020 18:59
@vuule vuule requested review from a team as code owners December 15, 2020 18:59
Copy link
Contributor

@galipremsagar galipremsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python changes LGTM

Co-authored-by: Karthikeyan <[email protected]>
@galipremsagar
Copy link
Contributor

rerun tests

@rapids-bot rapids-bot bot merged commit ff56585 into rapidsai:branch-0.18 Dec 17, 2020
@vuule vuule deleted the bug-misc-cleanup branch December 17, 2020 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuIO cuIO issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] read_orc_metadata docstring example is incorrect
4 participants