-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Fix concurrent JSON reads crash #6003
Conversation
…for decompression/upload
…ug-json-dangling-ptr
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve since this is a release blocker and I know cuIO code is going to undergo a refactor in the near future, but passing a view type by pointer is smelly.
…into bug-json-dangling-ptr
…ug-json-dangling-ptr
Changed the parameter to |
Codecov Report
@@ Coverage Diff @@
## branch-0.15 #6003 +/- ##
===============================================
- Coverage 88.65% 84.54% -4.11%
===============================================
Files 57 81 +24
Lines 10945 13845 +2900
===============================================
+ Hits 9703 11705 +2002
- Misses 1242 2140 +898
Continue to review full report at Codecov.
|
rerun tests |
1 similar comment
rerun tests |
rerun tests |
Closes: #5934
Root cause:
A temporary
unique_ptr
to amutable_table_device_view
object was being passed todevice_scalar
. The error only reproes if a concurrent thread/process changes the content at the temporary location - no repro with a singlethreaded read.Fix:
This PR contains a simple fix, and a few fixes for incorrect stream use in the JSON reader.